Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused (array) cast on array #9288

Merged
merged 1 commit into from
Nov 21, 2024
Merged

refactor: remove unused (array) cast on array #9288

merged 1 commit into from
Nov 21, 2024

Conversation

samsonasik
Copy link
Member

Description

when already array, no need to cast.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit 713c869 into codeigniter4:develop Nov 21, 2024
39 checks passed
@samsonasik samsonasik deleted the refactor-remove-cast-is-array branch November 21, 2024 03:02
@kenjis kenjis added the testing Pull requests that changes tests only label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis Awaiting requested review from kenjis

@MGatner MGatner Awaiting requested review from MGatner

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @paulbalandan @kenjis